PDA

View Full Version : suggestion, minor thing about header NetGame/connection.h



chumz
02-10-2013, 05:58 PM
Hi,
just a minor thing, when I include:

#include <ClanLib/Network/NetGame/connection.h>

I need to include first before it:

#include <vector>
#include <ClanLib/Core/Text/string_types.h>

All the other header include themself what they need,
so maybe you could do the same for this one.

Thanks

Judas
02-11-2013, 07:01 AM
Thanks. Committed a fix for this in the 2.3 and 3.0 branches.

The headers are meant to be safe to include directly. If you see more these kinds of bugs just let us know and we'll commit a fix.

chumz
02-12-2013, 05:50 PM
This also occures with other NetGame header (dunno if you have fix them all.)

For other similar things maybe you would prefer an email instead of a forum post? (to avoid anoying everyone with this.)

rombust
02-13-2013, 07:54 AM
To the forum, any developer with write access to SVN will then be able to apply it.

(From patches.txt )


If you have fixed or added something to ClanLib, here is a description
how to get those changes included in the official repository.

Diffing
===================================
Use 'diff -u > mypatch.patch' or 'svn diff > mypatch.patch' from within
the ClanLib (trunk) directory. This is contextual diff, it provides more
information so it easier to examine the changes before applying.

If you're using Windows, the TortoiseSVN utility
(http://tortoisesvn.tigris.org/) can easily create patches. Right click
your ClanLib directory (or trunk), and select TortoiseSVN->Create Patch.

Submitting
===================================
Please submit patches to our development forum:
Go to http://www.clanlib.org, click Forum, and go to Developer Chat subforum.

Describing
===================================
You should describe what your patch does. Please no 'This fixes a bug'.
Tell us which bug, in what component. Generally, be descriptive without
being being needlessly verbose.