Results 1 to 3 of 3

Thread: update-paint() patch SVN mistake

  1. #1
    ClanLib Developer
    Join Date
    May 2007
    Posts
    1,824

    Default update-paint() patch SVN mistake

    Whoops!

    Can someone undo: SVN 3851 "Fix the GUI texture manager update_paint(), so if there are any overlapping child window, it also receives the update request"

    It is incorrect.

    A child window should not require a repaint request - Because the CL_Texture rectangle of the child window is separate to the updated window.

    It was to fix a bug in GUICustomComponent.

    When the lines...
    //CL_TextureGroup texture_group(display_window.get_gc(), CL_Size(1024, 1024));
    //wm.set_texture_group(texture_group);

    ...are enabled, and you press left mouse button an the bottom left of the window (next to the toolbar). The toolbar graphics are overwritten.

    This is because request_repaint() is called by the radial-dial (indirectly via set_position).

    And for an unknown reason, the Toolbar window is overwritten.

    (The Z draw is correct, but something is exceeding the bound of the CL_SubTexture, from the main component texture window, onto the toolbar component texture window)

    I suspect the clip_rects have gone wrong somewhere, since the recent clip_rect patch.

  2. #2
    ClanLib Developer
    Join Date
    May 2007
    Posts
    1,824

    Default

    Thanks

    I forgot to think before coding

  3. #3
    ClanLib Developer
    Join Date
    May 2007
    Posts
    1,824

    Default

    Fixed

    cliprect.translate(subtexture_geometry.left, subtexture_geometry.top);
    + cliprect.overlap(subtexture_geometry);
    gc.set_cliprect(clip_rect);

Similar Threads

  1. Sprite Documentation update
    By huntercool in forum Official ClanLib SDK Forums
    Replies: 1
    Last Post: 09-03-2009, 02:12 PM
  2. Minor update to logger
    By CrazyFrazee in forum Official ClanLib SDK Forums
    Replies: 1
    Last Post: 01-25-2009, 09:31 PM
  3. CL 0.8 Canvas patch, get-rid-of-warnings patch
    By Trigve in forum Official ClanLib SDK Forums
    Replies: 2
    Last Post: 09-30-2007, 11:08 PM
  4. spelling mistake!
    By elite_coder in forum Dungeon Scroll for PC and iPhone
    Replies: 1
    Last Post: 09-06-2005, 02:44 AM
  5. Update?
    By licentious in forum RTsoft Tavern
    Replies: 5
    Last Post: 11-14-2002, 05:40 AM

Bookmarks

Bookmarks

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •