Results 1 to 6 of 6

Thread: Patch: Vertical scrollbar support for CL_TextEdit

  1. #1
    Lesser Knight
    Join Date
    Jan 2010
    Posts
    52

    Default Patch: Vertical scrollbar support for CL_TextEdit

    I added the vertical scrollbar to CL_TextEdit. I posted the full .cpp and .h in the "Help" forum, but I wanted to post the diff here.
    The scrollbar only appears when needed. I diffed it against ClanLib-2.4 in SVN. Again, if you want the full files instead of diffs, I posted them in "Help"
    Attached Files Attached Files

  2. #2
    ClanLib Developer
    Join Date
    May 2007
    Posts
    1,824

    Default

    The patch visually looks perfect.

    I won't apply it yet, until I get some feedback from others that use the GUI.

    Should the vertical scrollbar be configurable (i.e. is required or not) or automatically shown when required? I have no opinion, since I don't use the control

  3. #3
    ClanLib Developer
    Join Date
    Sep 2006
    Location
    Bergen, Norway
    Posts
    588

    Default

    Yes, should probably be configurable. The question is what should be default? And should they only appear when needed ? Maybe options could be None, Always, AsNeeded for both Horizontal and Vertical bars?

  4. #4
    Lesser Knight
    Join Date
    Jan 2010
    Posts
    52

    Default

    Quote Originally Posted by rombust View Post
    The patch visually looks perfect.

    I won't apply it yet, until I get some feedback from others that use the GUI.

    Should the vertical scrollbar be configurable (i.e. is required or not) or automatically shown when required? I have no opinion, since I don't use the control
    Well, multiple users have asked for it over on Help, and without it, if you keep typing in a text edit, your text goes down below where you can see it, which is bad.

    I'm fine with having it optional, though.

  5. #5
    ClanLib Developer
    Join Date
    May 2007
    Posts
    1,824

    Default

    Quote Originally Posted by Nightwind0 View Post
    ... if you keep typing in a text edit, your text goes down below where you can see it, which is bad.....
    For this reason, I suggest that we apply the patch as it is to ClanLib 2.4 SVN. The patch fixes the text edit usability.

    Additional patches can be created if a specific user requires configurability.

  6. #6
    ClanLib Developer
    Join Date
    Sep 2006
    Location
    Denmark
    Posts
    554

    Default

    Applied this patch. Thanks a lot.

Similar Threads

  1. CL_TextEdit
    By Jason Schilling in forum Official ClanLib SDK Forums
    Replies: 7
    Last Post: 08-13-2012, 02:41 AM
  2. FBO support
    By AxeD in forum Proton SDK
    Replies: 2
    Last Post: 03-14-2012, 08:26 PM
  3. Replies: 8
    Last Post: 03-04-2012, 07:38 AM
  4. CL_ListView, Scrollbar Ranges out of Bounds
    By ByteKiller in forum Official ClanLib SDK Forums
    Replies: 4
    Last Post: 05-27-2010, 01:52 PM
  5. CL 0.8 Canvas patch, get-rid-of-warnings patch
    By Trigve in forum Official ClanLib SDK Forums
    Replies: 2
    Last Post: 09-30-2007, 11:08 PM

Bookmarks

Bookmarks

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •