Results 1 to 4 of 4

Thread: suggestion, minor thing about header NetGame/connection.h

  1. #1

    Default suggestion, minor thing about header NetGame/connection.h

    Hi,
    just a minor thing, when I include:
    Code:
    #include <ClanLib/Network/NetGame/connection.h>
    I need to include first before it:
    Code:
    #include <vector>
    #include <ClanLib/Core/Text/string_types.h>
    All the other header include themself what they need,
    so maybe you could do the same for this one.

    Thanks

  2. #2
    ClanLib Developer
    Join Date
    Sep 2006
    Location
    Denmark
    Posts
    554

    Default

    Thanks. Committed a fix for this in the 2.3 and 3.0 branches.

    The headers are meant to be safe to include directly. If you see more these kinds of bugs just let us know and we'll commit a fix.

  3. #3

    Default

    This also occures with other NetGame header (dunno if you have fix them all.)

    For other similar things maybe you would prefer an email instead of a forum post? (to avoid anoying everyone with this.)

  4. #4
    ClanLib Developer
    Join Date
    May 2007
    Posts
    1,824

    Default

    To the forum, any developer with write access to SVN will then be able to apply it.

    (From patches.txt )
    Code:
    If you have fixed or added something to ClanLib, here is a description
    how to get those changes included in the official repository.
    
    Diffing
    ===================================
    Use 'diff -u > mypatch.patch' or 'svn diff > mypatch.patch' from within
    the ClanLib (trunk) directory. This is contextual diff, it provides more
    information so it easier to examine the changes before applying.
    
    If you're using Windows, the TortoiseSVN utility
    (http://tortoisesvn.tigris.org/) can easily create patches. Right click
    your ClanLib directory (or trunk), and select TortoiseSVN->Create Patch.
    
    Submitting
    ===================================
    Please submit patches to our development forum:
    Go to http://www.clanlib.org, click Forum, and go to Developer Chat subforum.
    
    Describing
    ===================================
    You should describe what your patch does. Please no 'This fixes a bug'.
    Tell us which bug, in what component. Generally, be descriptive without
    being being needlessly verbose.

Similar Threads

  1. The Saddest Thing Ever in FQ
    By redink1 in forum Funeral Quest
    Replies: 1
    Last Post: 04-13-2013, 02:38 PM
  2. Absolutely minor patches for iOS code
    By Philippe23 in forum Proton SDK
    Replies: 1
    Last Post: 03-26-2012, 11:41 PM
  3. Minor update to logger
    By CrazyFrazee in forum Official ClanLib SDK Forums
    Replies: 1
    Last Post: 01-25-2009, 09:31 PM
  4. Custom VirtualFileSource: inconvinient header location
    By Kez in forum Official ClanLib SDK Forums
    Replies: 1
    Last Post: 01-12-2009, 08:14 AM
  5. Minor reference error
    By mikael in forum Novashell Game Creation System
    Replies: 1
    Last Post: 07-09-2008, 11:12 PM

Bookmarks

Bookmarks

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •